Avoid capturing per-task RolloverResult #90626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today `TransportRolloverAction$RolloverExecutor` captures a `RolloverResult` for each task for use in the publication success callback. These things contain a cluster state which can be huge, and isn't necessary for the callback. With this commit we extract the fields we need instead, avoiding capturing the complete cluster state. Closes elastic#90620
DaveCTurner
added
>bug
:Data Management/Indices APIs
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Data Management
andreidan
approved these changes
Oct 4, 2022
Contributor
andreidan
left a comment
andreidan
left a comment
There was a problem hiding this comment.
Thanks for fixing this David, and thanks Armin for finding this issue (great catch!)
LGTM
original-brownbear
approved these changes
Oct 4, 2022
Collaborator
💚 Backport successful
|
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 4, 2022
Today `TransportRolloverAction$RolloverExecutor` captures a `RolloverResult` for each task for use in the publication success callback. These things contain a cluster state which can be huge, and isn't necessary for the callback. With this commit we extract the fields we need instead, avoiding capturing the complete cluster state. Closes elastic#90620
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 4, 2022
Today `TransportRolloverAction$RolloverExecutor` captures a `RolloverResult` for each task for use in the publication success callback. These things contain a cluster state which can be huge, and isn't necessary for the callback. With this commit we extract the fields we need instead, avoiding capturing the complete cluster state. Closes #90620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today
TransportRolloverAction$RolloverExecutorcaptures aRolloverResultfor each task for use in the publication success callback. These things contain a cluster state which can be huge, and isn't necessary for the callback. With this commit we extract the fields we need instead, avoiding capturing the complete cluster state.Closes #90620